Support non-generic AvaloniaProperty in GetObservable(converter)
#12160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty and a converter to a typed value Added missing docstrings for type params
TomEdwardsEnscape
changed the title
AvaloniaProperty in GetObservable(converter)
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jul 12, 2023
|
Can someone re-run the integration tests? |
|
You can test this PR using the following package version. |
TomEdwardsEnscape
deleted the
feature/untyped-property-observable-converter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight I made when adding converter methods to the
GetObservableextension methods in #10824. None of the new methods were compatible with the non-genericAvaloniaPropertybase type.What is the updated/expected behavior with this PR?
You can now provide a converter that can be applied to all
AvaloniaPropertyobjects. This is useful if you want to work with a shared base type of various properties, since you cannot cast (for example) anAvaloniaProperty<ListBox>object toAvaloniaProperty<ItemsControl>.Breaking changes
None
Obsoletions / Deprecations
None