Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pdb for ref assemblies #12410

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Aug 1, 2023

External symbols, pass 3

What is the current behavior?

Since #12216, pdb files for lib assemblies are external.

However, ref assemblies weren't modified:

  • ✔️ Stepping into code works for packages without ref assemblies (e.g. Avalonia.Skia).
  • ✔️ Stepping into code works for packages with ref assemblies (Avalonia main package) since lib assemblies are always involved when running/debugging.
  • ✔️ Navigating to definition works for packages without ref assemblies.
  • ❌ Navigating to definition doesn't work for package with ref assemblies.

The current ref assembly generator still embeds a pdb, but it's empty.
Visual Studio doesn't even fallback to the built-in decompiler in this case. Rider does.

What does the pull request do?

The GenerateRefAsmsInPackage has been rewritten to also patch the pdb files in the symbols package.

What is the updated/expected behavior with this PR?

Stepping into and navigating to definition work for all Avalonia packages in both Rider and Visual Studio.

Fixed issues

Fixes #12407

@maxkatz6 maxkatz6 enabled auto-merge August 1, 2023 21:51
auto-merge was automatically disabled August 2, 2023 06:54

Merge queue setting changed

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038275-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate to Source not working as of 11.0.1
3 participants