Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External symbols, pass 3
What is the current behavior?
Since #12216, pdb files for
lib
assemblies are external.However,
ref
assemblies weren't modified:ref
assemblies (e.g. Avalonia.Skia).ref
assemblies (Avalonia main package) sincelib
assemblies are always involved when running/debugging.ref
assemblies.ref
assemblies.The current ref assembly generator still embeds a pdb, but it's empty.
Visual Studio doesn't even fallback to the built-in decompiler in this case. Rider does.
What does the pull request do?
The
GenerateRefAsmsInPackage
has been rewritten to also patch the pdb files in the symbols package.What is the updated/expected behavior with this PR?
Stepping into and navigating to definition work for all Avalonia packages in both Rider and Visual Studio.
Fixed issues
Fixes #12407