Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass NoWarn to external MSBuild processes #12647

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

TomEdwardsEnscape
Copy link
Contributor

This change allows users to suppress Avalonia XAML compile warnings by adding the warning codes to the standard MSBuild NoWarn property.

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Fixes #11312

@TomEdwardsEnscape
Copy link
Contributor Author

@dotnet-policy-service agree company="Enscape"

@TomEdwardsEnscape
Copy link
Contributor Author

TomEdwardsEnscape commented Aug 23, 2023

Seems that this only worked on my machine because the value of AvaloniaUseExternalMSBuild is cached somewhere until you restart Visual Studio. I'll keep digging until multiple warning suppressions can be passed.

Fixed

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0038726-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 24, 2023
@maxkatz6 maxkatz6 removed this pull request from the merge queue due to a manual request Sep 24, 2023
@maxkatz6 maxkatz6 merged commit ab3690c into AvaloniaUI:master Sep 24, 2023
@TomEdwardsEnscape TomEdwardsEnscape deleted the fixes/nowarn branch September 24, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogus warning when a TopLevel does not have a parameterless constructor
3 participants