Implemented Geometry.GetWidenedGeometry. #12724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
commented
Aug 30, 2023
kekekeks
reviewed
Aug 30, 2023
kekekeks
reviewed
Aug 30, 2023
|
You can test this PR using the following package version. |
Otherwise we'd be changing the behavior of an existing API (`StrokeContains`) which should be discussed first.
|
You can test this PR using the following package version. |
- Move the logic into `SKPathHelper.CreateStrokedPath`; called from `PathHelper` and `GetWidenedGeometry` - Use a pen hash code to check if we're up-to-date in `PathHelper` and include the dash style in that
maxkatz6
reviewed
Aug 31, 2023
kekekeks
reviewed
Aug 31, 2023
kekekeks
approved these changes
Aug 31, 2023
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
grokys
added
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Implements
Geometry.GetWidenedGeometry. Similar to the WPF methodGeometry.GetWidenedPathGeometryexcept that it doesn't return aPathGeometryand there is no overload with tolerance settings.