Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made clear behavior in RenderTargetBitmap.CreateDrawingContext optional #12793

Merged
merged 9 commits into from
Sep 10, 2023
Merged

Made clear behavior in RenderTargetBitmap.CreateDrawingContext optional #12793

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
867dbea
Made clear behavior in RenderTargetBitmap.CreateDrawingContext optional
PMahern Sep 5, 2023
28e8388
Merge branch 'master' into feature/optional-clear-in-rendertargetbitm…
PMahern Sep 6, 2023
29c84b1
Added updated Avalonia.nupkg.xml
PMahern Sep 6, 2023
1ca0ee6
Merge branch 'master' into feature/optional-clear-in-rendertargetbitm…
PMahern Sep 6, 2023
9e94055
Added a function to RenderTargetBitmap to create a DrawingContext for…
PMahern Sep 8, 2023
6a5f995
Merge branch 'feature/optional-clear-in-rendertargetbitmap-createdraw…
PMahern Sep 8, 2023
758cf62
Merge branch 'master' into feature/optional-clear-in-rendertargetbitm…
PMahern Sep 8, 2023
59d14dd
Update RenderTargetBitmap.cs
PMahern Sep 8, 2023
3c44afc
Merge branch 'master' into feature/optional-clear-in-rendertargetbitm…
PMahern Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Avalonia.Base/Media/Imaging/RenderTargetBitmap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,24 @@ private static IRenderTargetBitmapImpl CreateImpl(PixelSize size, Vector dpi)
return factory.CreateRenderTargetBitmap(size, dpi);
}

/// <summary>
/// Creates a <see cref="DrawingContext"/> for drawing to the <see cref="RenderTargetBitmap"/>.
/// Clears the current image data to transparent.
/// </summary>
/// <returns>The drawing context.</returns>
public DrawingContext CreateDrawingContext()
=> CreateDrawingContext(true);

/// <summary>
/// Creates a <see cref="DrawingContext"/> for drawing to the <see cref="RenderTargetBitmap"/>.
/// </summary>
/// <param name="clear">If true, clears the current image data to transparent, if false, leaves the image data unchanged.</param>
/// <returns>The drawing context.</returns>
public DrawingContext CreateDrawingContext(bool clear)
{
var platform = PlatformImpl.Item.CreateDrawingContext();
platform.Clear(Colors.Transparent);
if(clear)
platform.Clear(Colors.Transparent);
return new PlatformDrawingContext(platform);
}

Expand Down