Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WindowNotificationManager: support TopCenter and BottomCenter position #12804

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

rabbitism
Copy link
Contributor

What does the pull request do?

Add TopCenter and BottomCenter option to WindowNotificationManager.
These are frequently used.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039240-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0039257-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 24, 2023
@maxkatz6 maxkatz6 added this pull request to the merge queue Sep 24, 2023
Merged via the queue into AvaloniaUI:master with commit db7cbaa Sep 24, 2023
@rabbitism rabbitism deleted the notification branch October 1, 2023 12:21
@rabbitism
Copy link
Contributor Author

Hi consider backport this to 11.0.x?

@maxkatz6
Copy link
Member

I can add a tack, but no more backports are planned for 11.0.x, unless there are critical bugs or customer's request.

@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Mar 20, 2024
maxkatz6 pushed a commit that referenced this pull request Apr 6, 2024
…osition (#12804)

* feat: support topcenter and bottom center.

* fix: fix typo.
@maxkatz6 maxkatz6 removed the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants