perf: Micro optimization EndsWith using

[workgroupengineering]

What does the pull request do?

• Replace ToLowerInvariant().EndsWith with EndsWith("string", StringComparison.OrdinalIgnoreCase)
• Replace value.EndsWith("%") with value[value.Length -1 ] == '%'

What is the current behavior?

What is the updated/expected behavior with this PR?

small decrease in memory usage during build

How was the solution implemented (if it's not obvious)?

BenchmarkDotNet v0.13.8, Windows 10 (10.0.19045.3448/22H2/2022Update)
Intel Core i5-10400 CPU 2.90GHz, 1 CPU, 12 logical and 6 physical cores
.NET SDK 7.0.401
  [Host]     : .NET 6.0.22 (6.0.2223.42425), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.22 (6.0.2223.42425), X64 RyuJIT AVX2

Method	Mean	Error	StdDev	Median	Ratio	Gen0	Allocated	Alloc Ratio
ToLowerInvariant_EndsWith	193.712 ms	3.3250 ms	3.1102 ms	193.146 ms	1.00	6000.0000	38600893 B	1.000
EndsWith_With_StringComparison	3.959 ms	0.2222 ms	0.6411 ms	3.761 ms	0.02	-	2 B	0.000

BenchmarkDotNet v0.13.8, Windows 10 (10.0.19045.3448/22H2/2022Update)
Intel Core i5-10400 CPU 2.90GHz, 1 CPU, 12 logical and 6 physical cores
.NET SDK 7.0.401
  [Host]     : .NET 6.0.22 (6.0.2223.42425), X64 RyuJIT AVX2
  DefaultJob : .NET 6.0.22 (6.0.2223.42425), X64 RyuJIT AVX2

Method	Mean	Error	StdDev	Median	Ratio	RatioSD	Allocated	Alloc Ratio
InvariantCultureIgnoreCase	4.064 ms	0.2365 ms	0.6935 ms	3.874 ms	1.00	0.00	2 B	1.00
OrdinalIgnoreCase	1.490 ms	0.0280 ms	0.0691 ms	1.457 ms	0.36	0.06	1 B	0.50

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0040249-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[MrJul]

For EndsWith with a single char, .NET Core 2+ and .NET Standard 2.1 already have an optimized String.EndsWith(char).

Since we still need to target .NET Standard 2.0, can you please add its equivalent with conditional compilation to StringCompatibilityExtensions and use it instead? This way we get the framework built-in one in .NET 6+ and we'll be able to easily remove the polyfill later without any other change.

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0040342-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]