Fix previewing XAML in the Simple theme project #13394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Oct 26, 2023
|
Please consider adding the "hacktoberfest-accepted" label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Adds a reference to the Simple theme in the Sandbox project to enable previewing XAML in the Simple theme project.
What is the current behavior?
What is the updated/expected behavior with this PR?
Previewing XAML in the Simple theme works
How was the solution implemented (if it's not obvious)?
Add reference to the Simple theme project in the Sandbox project. This makes the previewer find the Sandbox project before the Benchmarks project, which does not work for the previewer.
Checklist
Breaking changes
None
Related discussion
Thanks to @timunie for pointing out the problem in #13392.