Fix ScrollContentPresenter incorrectly handling BringIntoView when offset is coerced #14913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
the
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 11, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
…fset is coerced (#14913) * Added failing test for nested ScrollContentPresenters w/o rounding * Fix SCP.BringDescendantIntoView with coerced offset
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
A bit similar to #14900, this PR makes sure that
ScrollContentPresenter.BringDescendantIntoViewdoesn't handle theRequestBringIntoViewif the offset happened to be coerced back to its previous value, which can be the case for rounding errors.A unit test has been added.
Fixed issues