Fix font fallback for composite keys containing relative URIs #14943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
the
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Mar 13, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
* Add failing test for font fallback with relative URI * Fix font fallback for composite keys containing relative URIs
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes the font fallback mechanism throwing whenever a fallback character is needed for a composite key containing a relative URI.
A unit test has been added.
What is the current behavior?
The application crashes with System.InvalidOperationException: This operation is not supported for a relative URI.
What is the updated/expected behavior with this PR?
The font fallback works.
Note
The removal of
if (source.Scheme == SystemFontScheme) return SystemFonts.TryGetGlyphTypeface(...)isn't an error: it's an intended simplification sinceGetFontCollectionalready has a special case forSystemFontScheme.