Fix TextBox sync issues #14960
Fix TextBox sync issues #14960
Conversation
…text input is handled
Gillibald
added
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
| //Make sure updated text is in sync | ||
| _presenter?.SetCurrentValue(TextPresenter.TextProperty, text); | ||
|
|
||
| caretIndex += input.Length; |
There was a problem hiding this comment.
input.Length is added twice, here and on SetCurrentValue(CaretIndexProperty..., ) below, moving the effective caret twice (the visual one is correct).
Shouldn't we add some small unit test ensuring that TextBox.CaretIndex == _presenter.CaretIndex in the bugged cases after input?
There was a problem hiding this comment.
Good catch. These unit tests tend to be hard to write because of the property sync. I am having a look. All these issues are caused by the fact that some state is synced via bindings.
…a into fixes/textBoxCaretSync
|
You can test this PR using the following package version. |
* Sync change text and changed caret index with the TextPresenter when text input is handled * Do not add length again
* Sync change text and changed caret index with the TextPresenter when text input is handled * Do not add length again
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #13648
Fixes #13886
Fixes #14563