Fixes/drawing brush transform #14978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resulting SKShader
Implement Direct2D1
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 15, 2024
kekekeks
reviewed
Mar 15, 2024
| @@ -1186,15 +1191,6 @@ private void ConfigureTileBrush(ref PaintWrapper paintWrapper, Rect targetBox, I | |||
| paintTransform = SKMatrix.Concat(paintTransform, | |||
| SKMatrix.CreateScale((float)(96.0 / _intermediateSurfaceDpi.X), (float)(96.0 / _intermediateSurfaceDpi.Y))); | |||
|
|
|||
| if (tileBrush.Transform is { }) | |||
| { | |||
| var origin = tileBrush.TransformOrigin.ToPixels(targetRect); | |||
There was a problem hiding this comment.
Transform origin shouldn't be ignored
|
I am afraid this PR breaks some things @Gillibald Before the PR (matches WPF): After the PR: |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
* Apply brush transform to SKPicture instead to the local matrix of the resulting SKShader * Add unit test Implement Direct2D1
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures a brush transform is applied to the brush's content instead of on the resulting platform brush.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues