Use ShowWindowCommand.Hide when positioning an unshown win32 window #15035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
…ot yet been shown
TomEdwardsEnscape
force-pushed
the
fixes/unshown-window-resize
branch
from
88d21db to
6c6d1b2
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 20, 2024
maxkatz6
added
backport-candidate-11.1.x
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition when these conditions are met:
WindowStartupLocation="CenterScreen"Widthand/orHeightare defined(
Thread.Sleepcan be called inOnApplyTemplateto artificially fulfil the third requirement.)In this situation, the window can be seen opening in one location then later moving to another location. This seems to be happening because it isn't centred on the screen until measured? In any case, the PR fixes the issue by keeping the window hidden until it is shown.
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #15003