Set capacity of XAML resource dictionaries #15069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
kekekeks
reviewed
Mar 22, 2024
MrJul
force-pushed
the
feature/xaml-rd-capacity
branch
from
7929709 to
c82f8a5
Compare
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Mar 24, 2024
| /// Ensures that the resource dictionary can hold up to <paramref name="capacity"/> entries without | ||
| /// any further expansion of its backing storage. | ||
| /// </summary> | ||
| /// <remarks>This method may have no effect when targeting .NET Standard 2.0.</remarks> |
There was a problem hiding this comment.
This remark is partially outdated now.
There was a problem hiding this comment.
I've changed it to "may have" since it's still true that it doesn't do anything when on .NET standard and the inner dictionary is already initialized.
maxkatz6
approved these changes
Mar 24, 2024
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 20, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adds a new
EnsureCapacitytoResourceDictionary, used to prepare its backing storage for new items.The XAML compiler now calls this method before adding items to the
ResourceDictionary, since it knows how many will be added.This avoids expanding the capacity several times at startup (for example,
FluentThemehas dictionaries with up to 709 items), saving memory allocations.