Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltips not closing when the pointer leaves the window #15312

Merged
merged 1 commit into from
May 2, 2024

Conversation

TomEdwardsEnscape
Copy link
Contributor

Fixes a mistake I made in #14928. If a tooltip is open and the pointer leaves the window without first leaving the tooltip control, the tooltip does not close. The easiest way to replicate this is to create a control which fills the entire window (with no margin) and give it a tooltip.

This PR will conflict with #15259. I still submitted this fix separately because #15259 includes a change in behaviour, and it's not clear whether it will be added to 11.1.

Breaking changes

None

Obsoletions / Deprecations

None

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047154-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member

@TomEdwardsEnscape I will push the other PR to 11.1, so it can be part of 11.1 version behavioral changes. This way it would be better than waiting for 11.2/12.0 or even worse in 11.1.1.

@TomEdwardsEnscape TomEdwardsEnscape force-pushed the fixes/tooltip-leave-window branch from 8cc6ea0 to 1ed496e Compare April 11, 2024 07:29
@TomEdwardsEnscape
Copy link
Contributor Author

TomEdwardsEnscape commented Apr 11, 2024

Sometimes on MS Windows we receive a window exit event when a tooltip opens, but before the pointer has been detected over the tooltip. This causes the tooltip to incorrectly close.

This seems to be an upstream issue, probably related to #13036, and I don't think that anything can or should be done about it in ToolTipService.

@maxkatz6
Copy link
Member

Some tests are failing

@TomEdwardsEnscape
Copy link
Contributor Author

I don't currently have time to work on this, if it needs to be done soon then please can someone else take over.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047906-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Apr 30, 2024

  • All contributors have signed the CLA.

@TomEdwardsEnscape
Copy link
Contributor Author

@cla-avalonia agree

@TomEdwardsEnscape
Copy link
Contributor Author

The Windows integration tests failed, but the failures seem unrelated to this PR's changes.

@maxkatz6
Copy link
Member

maxkatz6 commented Apr 30, 2024

These specific tests were fixed in master, need to merge/rebase.

@TomEdwardsEnscape TomEdwardsEnscape force-pushed the fixes/tooltip-leave-window branch from 3e6fbcf to 7c00ed0 Compare May 2, 2024 06:35
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048016-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue May 2, 2024
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label May 2, 2024
Merged via the queue into AvaloniaUI:master with commit ff021aa May 2, 2024
11 checks passed
@TomEdwardsEnscape TomEdwardsEnscape deleted the fixes/tooltip-leave-window branch May 2, 2024 15:12
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants