-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tooltips not closing when the pointer leaves the window #15312
Conversation
You can test this PR using the following package version. |
@TomEdwardsEnscape I will push the other PR to 11.1, so it can be part of 11.1 version behavioral changes. This way it would be better than waiting for 11.2/12.0 or even worse in 11.1.1. |
8cc6ea0
to
1ed496e
Compare
Sometimes on MS Windows we receive a window exit event when a tooltip opens, but before the pointer has been detected over the tooltip. This causes the tooltip to incorrectly close. This seems to be an upstream issue, probably related to #13036, and I don't think that anything can or should be done about it in |
Some tests are failing |
I don't currently have time to work on this, if it needs to be done soon then please can someone else take over. |
1ed496e
to
3e6fbcf
Compare
You can test this PR using the following package version. |
|
@cla-avalonia agree |
The Windows integration tests failed, but the failures seem unrelated to this PR's changes. |
These specific tests were fixed in master, need to merge/rebase. |
3e6fbcf
to
7c00ed0
Compare
You can test this PR using the following package version. |
Fixes a mistake I made in #14928. If a tooltip is open and the pointer leaves the window without first leaving the tooltip control, the tooltip does not close. The easiest way to replicate this is to create a control which fills the entire window (with no margin) and give it a tooltip.
This PR will conflict with #15259. I still submitted this fix separately because #15259 includes a change in behaviour, and it's not clear whether it will be added to 11.1.
Breaking changes
None
Obsoletions / Deprecations
None