Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new run loop observer for a nested loop if it's being started from an observer callback #15425

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

kekekeks
Copy link
Member

With the current implementation timers become completely broken if Dispatcher.PushFrame is called from a timer callback.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047407-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys added this pull request to the merge queue Apr 18, 2024
Merged via the queue into master with commit 27e40b8 Apr 18, 2024
11 checks passed
@grokys grokys deleted the fixes/macos-dispatcher-callbacks-in-nested-loops branch April 18, 2024 14:02
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Apr 18, 2024
maxkatz6 pushed a commit that referenced this pull request Apr 20, 2024
…d from an observer callback (#15425)

Co-authored-by: Nikita Tsukanov <kekekeks@Nikitas-MacBook-Pro.local>
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label May 6, 2024
grokys pushed a commit that referenced this pull request Jun 11, 2024
…d from an observer callback (#15425)

Co-authored-by: Nikita Tsukanov <kekekeks@Nikitas-MacBook-Pro.local>
@grokys grokys added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jun 11, 2024
grokys pushed a commit that referenced this pull request Jun 12, 2024
…d from an observer callback (#15425)

Co-authored-by: Nikita Tsukanov <kekekeks@Nikitas-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants