-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DBus stack #15568
Bump DBus stack #15568
Conversation
- Use new Variant system
You can test this PR using the following package version. |
|
@cla-avalonia agree |
…-tmds-dbus-sourcegenerator
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested LGTM
Can we please actually check returned types instead of assuming those? We are dealing with Linux DEs after all, those aren't really known for following specs. |
* Bump DBus stack - Use new Variant system * Fix merge issues (cherry picked from commit 5956ae7)
* Add private app init * add todo * update TrayIcon.cs * add debugging message for now * Reapply "Bump DBus stack (#15568)" (#15656) This reverts commit e787bb4. * update dbus stuff * DBus init and usage fixes * revert application class changes * Revert "DBus init and usage fixes" This reverts commit 833da08. * dont dispose the thrown exception on DBusTrayIconImpl.cs * Update src/Avalonia.FreeDesktop/DBusTrayIconImpl.cs Co-authored-by: Max Katz <maxkatz6@outlook.com> --------- Co-authored-by: Nikita Tsukanov <keks9n@gmail.com> Co-authored-by: Max Katz <maxkatz6@outlook.com>
What does the pull request do?
Bump Tmds.DBus.Protocol and Tmds.DBus.SourceGenerator.
This uses the "official" Variant system instead of the SourceGenerator provided one (which was removed).
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
None