Make integrational tests compatible with Appium 2 #15570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
area-infrastructure
grokys
approved these changes
Apr 30, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
added a commit
that referenced
this pull request
Aug 12, 2024
* Make it work on macOS * Revert most of changes This reverts commit 3526c6f. * Polyfill appium2, make it usable with both versions * Revert unrelated changes * Fix slider incompatibility
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
For some reason, Appium 1 doesn't work anymore on some dev's machines, including me.
Since we can't really fully migrate to Appium 2 because of WinAppDriver being dead, we have to sit on two chairs at once.
This PR adds a MSBuild property to switch between Appium 1 and Appium 2 used in the project.
By default, we still use Appium 1, which also the case for all CI builds.
But if anybody want to use Appium 2 locally, after this PR they need to:
appium --base-path=/wd/hub.