Fix crash when linux tray icon's visibility is toggled on/off. #15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacato
changed the title
|
You can test this PR using the following package version. |
kekekeks
approved these changes
May 1, 2024
jmacato
force-pushed
the
dbus-remove-handler-hack
branch
from
323620d to
84a4dde
Compare
jmacato
changed the title
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
May 8, 2024
* Call RemoveMethodHandlers to "dispose" method handlers in dbus tray icons. * just move the handler to the ctor and remove the reflection hacks
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to access the internal RemoveMethodHandler api so that we can "dispose" of the SNI handler on the dbus connection. Some sub-optimal distros is quite sensitive to this so they crash the app instead.Seems like the protocol itself is broken so we're forced to make a new DBus connection for each trayicon object we made on avalonia side and to hide/show, we'll just create/destroy the service name and preserve the handlers to avoid the reflection hacks needed to call RemoveMethodHandler.