Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Tooltip edge case fixes #15596

Merged
merged 1 commit into from
May 6, 2024

Conversation

TomEdwardsEnscape
Copy link
Contributor

  • Never update ToolTipService while the mouse is over a tooltip (fixes flicker when redrawing a window beneath the pointer)
  • Avoid race condition where a dispatcher timer callback exectues right after we stopped the timer
  • Fix not closing a tooltip when its pointer exit event is the last input sent to Avalonia

The first two issues pre-date the recent tooltip service changes.

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Fixes #15486

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048058-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label May 3, 2024
…flicker when redrawing a window beneath the pointer)

Avoid race condition where a dispatcher timer callback exectues right after we stopped the timer
Fix not closing a tooltip when its pointer exit event is the last input sent to Avalonia
@TomEdwardsEnscape TomEdwardsEnscape force-pushed the fixes/tooltip-flicker branch from e6ff44e to 8b0a8c9 Compare May 4, 2024 06:43
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048062-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 76f4e7a into AvaloniaUI:master May 6, 2024
11 checks passed
@TomEdwardsEnscape TomEdwardsEnscape deleted the fixes/tooltip-flicker branch May 6, 2024 11:27
maxkatz6 pushed a commit that referenced this pull request May 8, 2024
…flicker when redrawing a window beneath the pointer) (#15596)

Avoid race condition where a dispatcher timer callback exectues right after we stopped the timer
Fix not closing a tooltip when its pointer exit event is the last input sent to Avalonia
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flickering cursor over a Button with ToolTip in the bottom right corner
3 participants