Don't show text selector when no text is ready

[emmauss]

What does the pull request do?

When there's no text in a textbox, tapping it will not show the selection handles.

What is the current behavior?

Text selectors always show even when there's no text to select.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #15694

[avaloniaui-bot]

You can test this PR using the following package version. 11.2.999-cibuild0048537-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[robloo]

On Android with Samsung S23 (not using Avalonia) here is the functionality.

1. First tap into empty textbox the cursor appears.
2. Second tap into an empty textbox the cursor AND selection handle appears and the Paste, etc. Context menu opens.

I think you are oversimplifying this a bit and the selection handle is useful user feedback in some cases. At least it makes clear where the cursor is.

[emmauss]

On Android with Samsung S23 (not using Avalonia) here is the functionality.

1. First tap into empty textbox the cursor appears.

2. Second tap into an empty textbox the cursor AND selection handle appears and the Paste, etc. Context menu opens.

I think you are oversimplifying this a bit and the selection handle is useful user feedback in some cases. At least it makes clear where the cursor is.

I'm only able to show the handles on an empty textbox when you long press. This both shows the context menu and the handle. Tapping doesn't. Imho, there isn't a purpose of the handle when the textbox is empty, as no selection can occur, and context menu will still show with long press

[robloo]

In Samsung OneUI this is what I see:

Single tap:

Tap once, wait and tap again:

Edit: And a purpose of this might be strong user feedback in the UI where text input will occur. This is easier to see than a blinking cursor in some cases. I also expect that the selection handles and context menu are always shown together.

We probably need to know what is done in iOS as well.

[emmauss]

Yeah. We need to check how iOS handles it

[maxkatz6]

First tap into empty textbox the cursor appears.
Second tap into an empty textbox the cursor AND selection handle appears and the Paste, etc. Context menu opens.

On iOS:

1. First tap shows the cursor
2. Second tap shows the context menu, but not the selection handle
3. Selection handle only appears if field is not empty, and user double tapped on the text (long press only moves the cursor).

Some apps (mostly, messengers) actually select all the text on second tap as well. But it seems to be a custom behavior.

[emmauss]

Flutter seems to use the android behavior(long press to show handle and menu) when using the material theme, and no showing when using cupertino(ios)

[robloo]

Flutter matching the host OS behavior seems correct to me. That could definitely be debated though.

[robloo]

So... the discussion was invalidated and we just merged as is?

[maxkatz6]

@robloo on both iOS and Android selection handle doesn't appear when input is focused. Only on second tap with a difference whether field is empty or not (Android will show the handle when empty, iOS will show the handle when there is some text).
This PR makes first common part better by not showing it immediately.
I wouldn't keep this PR open until it gets platform specific implementations to complete second part, as it's not planned now.

We need an issue to track that though.