fix #15873, prevent FontFamily Property was null and crash the whole application #15896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luoyingliang
changed the title
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Jul 16, 2024
|
You can test this PR using the following package version. |
maxkatz6
added
bug
backport-candidate-11.1.x
maxkatz6
added
customer-priority
maxkatz6
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
this PR fix when FontFamily Property assign a {x:Null} value by xaml, will crash whole application, i added a null check for Typeface.FontFamily.
What is the current behavior?
FontManager will not check the null reference of Typeface.FontFamily null reference, if this property was null, will not fallback to DefaultFontFamily, and crash whole application. I think for the application robustness, it's should be checked.
What is the updated/expected behavior with this PR?
when Typeface.FontFamily property was null, it can fallback to default family
How was the solution implemented (if it's not obvious)?
Add a simple null-coalescing
Fixed issues
Fixes #15873