macOS: Don't include two windows in a11y tree. #15899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AvnRootAccessibilityElement` has been removed and now `AvnWindow` handles the accessibility protocol itself, exposing its children via the `AvnView`.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jun 5, 2024
|
This PR will conflcit with #15800, so need to carefully decide which to merge first. |
|
You can test this PR using the following package version. |
Gillibald
pushed a commit
to Gillibald/Avalonia
that referenced
this pull request
Jul 29, 2024
* Don't include two windows in a11y tree. `AvnRootAccessibilityElement` has been removed and now `AvnWindow` handles the accessibility protocol itself, exposing its children via the `AvnView`. * Remove hack now that issue is fixed. * Fix build errors after merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Previously due to the way we were handling the macOS accessibility/automation APIs, two Windows were showing up in the accessibility tree.
This fixes that so that there is only a single Window showing up. To do this,
AvnRootAccessibilityElementhas been removed and nowAvnWindowhandles the accessibility protocol itself, exposing its children via theAvnView.The integration tests have been updated to no longer expect an extraneous Window in the automation tree.
As part of this working, I also started moving various classes outside of
accessibility.mm/.hand into their own files to make navigation in xcode a little easier.Before:
After: