Use the owner window's screen as the constraint. #15910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14982 added some logic from WPF to contrain a window showed with `WindowStartupLocation.CenterOwner` to the screen, but it had a bug: the screen used was the screen that the window being _shown) is currently on, not the _owner_ window. This means that if the owner window is on a different screen to the window being shown then it will be constrained to the wrong screen. You can see this on Windows by showing a child `Window` with `CenterOwner` when the owner window is on a secondary screen: the child window will initially be shown on the primary screen and so the constraint will be wrong, resulting in the child window being shown on the wrong screen.
grokys
added
bug
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Jun 4, 2024
grokys
added
customer-priority
grokys
added a commit
that referenced
this pull request
Aug 8, 2024
#14982 added some logic from WPF to contrain a window showed with `WindowStartupLocation.CenterOwner` to the screen, but it had a bug: the screen used was the screen that the window being _shown) is currently on, not the _owner_ window. This means that if the owner window is on a different screen to the window being shown then it will be constrained to the wrong screen. You can see this on Windows by showing a child `Window` with `CenterOwner` when the owner window is on a secondary screen: the child window will initially be shown on the primary screen and so the constraint will be wrong, resulting in the child window being shown on the wrong screen.
maxkatz6
pushed a commit
that referenced
this pull request
Aug 12, 2024
#14982 added some logic from WPF to contrain a window showed with `WindowStartupLocation.CenterOwner` to the screen, but it had a bug: the screen used was the screen that the window being _shown) is currently on, not the _owner_ window. This means that if the owner window is on a different screen to the window being shown then it will be constrained to the wrong screen. You can see this on Windows by showing a child `Window` with `CenterOwner` when the owner window is on a secondary screen: the child window will initially be shown on the primary screen and so the constraint will be wrong, resulting in the child window being shown on the wrong screen.
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
#14982 added some logic from WPF to contrain a window showed with
WindowStartupLocation.CenterOwnerto the screen, but it had a bug: the screen used was the screen that the window being shown is currently on, not the owner window.This means that if the owner window is on a different screen to the window being shown then it will be constrained to the wrong screen.
You can see this on Windows by showing a child
WindowwithCenterOwnerwhen the owner window is on a secondary screen: the child window will initially be shown on the primary screen and so the constraint will be wrong, resulting in the child window being shown on the wrong screen.