Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores WS_CHILD style for Embedded Windows #16051

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

fitdev
Copy link
Contributor

@fitdev fitdev commented Jun 18, 2024

What does the pull request do?

Restore WS_CHILD window style for embedded windows.

What is the current behavior?

Embedded windows in hosted scenarios are not child windows causing all sorts of focus and other issues.

What is the updated/expected behavior with this PR?

Embedded windows will have WS_CHILD style applied.

Checklist

Fixed issues

Fixes #16048

fitdev added 2 commits June 18, 2024 11:33
Restore WS_CHILD window style for embedded windows.
Should fix: AvaloniaUI#16048
Restore WS_CHILD window style for Embedded Windows
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049097-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Jun 18, 2024

  • All contributors have signed the CLA.

@fitdev
Copy link
Contributor Author

fitdev commented Jun 18, 2024

@cla-avalonia agree

@maxkatz6 maxkatz6 requested a review from emmauss June 18, 2024 18:29
@fitdev
Copy link
Contributor Author

fitdev commented Jul 1, 2024

@emmauss Is there an issue with this PR?

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049685-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 1, 2024
@maxkatz6 maxkatz6 added bug os-windows backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 1, 2024
Merged via the queue into AvaloniaUI:master with commit aed7f3e Jul 1, 2024
11 checks passed
@maxkatz6 maxkatz6 added regression backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 12, 2024
maxkatz6 pushed a commit that referenced this pull request Aug 12, 2024
Restore WS_CHILD window style for embedded windows.
Should fix: #16048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 11.1 Beta2 and RC1 concerning EmbeddableControlRoot's EmbeddableWindow implementation on Windows
5 participants