-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restores WS_CHILD style for Embedded Windows #16051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore WS_CHILD window style for embedded windows. Should fix: AvaloniaUI#16048
Restore WS_CHILD window style for Embedded Windows
You can test this PR using the following package version. |
|
@cla-avalonia agree |
@emmauss Is there an issue with this PR? |
emmauss
approved these changes
Jul 1, 2024
You can test this PR using the following package version. |
maxkatz6
added
bug
os-windows
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
labels
Jul 1, 2024
maxkatz6
added
regression
backported-11.1.x
and removed
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
labels
Aug 12, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Aug 12, 2024
Restore WS_CHILD window style for embedded windows. Should fix: #16048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Restore WS_CHILD window style for embedded windows.
What is the current behavior?
Embedded windows in hosted scenarios are not child windows causing all sorts of focus and other issues.
What is the updated/expected behavior with this PR?
Embedded windows will have WS_CHILD style applied.
Checklist
Fixed issues
Fixes #16048