Fix compiled binding indexer always forcing integer boxing #16109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
area-xaml
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
grokys
approved these changes
Jun 25, 2024
maxkatz6
added a commit
that referenced
this pull request
Aug 12, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Working on #16108 I noticed invalid IL warnings produced by AOT compiler.
Apparently, our indexer setter were always invalid, at least with compiled bindings.
Didn't find any opened issues, but repro is pretty simple - any twoway binding to the indexer property.
Checklist