-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nunit tests adapter losing async locals #16157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
area-headless
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
labels
Jun 28, 2024
You can test this PR using the following package version. |
You can test this PR using the following package version. |
kekekeks
approved these changes
Jul 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 17, 2024
grokys
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Fix NUnit test context not being properly set * Add failing tests * Capture ExecutionContext to keep async locals * Remove explicit EstablishExecutionEnvironment call, as it was a bad idea * Make ExecutionContext usage disabled by default, and only enabled for NUnit
grokys
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Fix NUnit test context not being properly set * Add failing tests * Capture ExecutionContext to keep async locals * Remove explicit EstablishExecutionEnvironment call, as it was a bad idea * Make ExecutionContext usage disabled by default, and only enabled for NUnit
grokys
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Fix NUnit test context not being properly set * Add failing tests * Capture ExecutionContext to keep async locals * Remove explicit EstablishExecutionEnvironment call, as it was a bad idea * Make ExecutionContext usage disabled by default, and only enabled for NUnit
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Consider this PR for backporting to 11.1 branch
labels
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
NUnit actively uses
AsyncLocal
to globally storeTestContext
.Avalonia Headless integration with NUnit was messing up with
ExecutionContext
causing weird bugs like:How was the solution implemented (if it's not obvious)?
I couldn't understand exactly how was it broken, but my hypothesis is:
ExecutionContext
.TestContext
in theAsyncLocal
(which uses ExecutionContext) - https://github.com/nunit/nunit/blob/v3.13.3/src/NUnitFramework/framework/Internal/TestExecutionContext.cs#L154TestContext
of the first running test, caches it, and never invalidates.TestContext
via EstablishExecutionEnvironment. But it has no effect on Avalonia Tests, which don't use the sameExecutionContext
.EstablishExecutionEnvironment
on each tests also doesn't work, as it resetsSynchronizationContext
(!!!!) to NUnit's one as well, breaking anything Dispatcher related.And it was fixed by explicitly capturing
ExecutionContext
of the invoking test framework (NUnit in this case), and explicitly running tests in the same context, while keeping our ownSynchronizationContext
.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues