Fix IME not working in some scenarios. #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If other services trigger `OnNameChange` before `GetNameOwnerAsync`, then we will incorrectly connect to other services, and will be stuck at `Connect`. We should ignore irrelevant services. * `WatchNameOwnerChangedAsync` should be called only once.
|
You can test this PR using the following package version. |
maxkatz6
added
bug
os-linux
backport-candidate-11.1.x
maxkatz6
reviewed
Jul 26, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
If other service trigger
OnNameChangebeforeGetNameOwnerAsync, then we will incorrectly connect to other service, and will be stuck atConnect. We should ignore irrelevant services.WatchNameOwnerChangedAsyncshould be called only once.d7904b3 changed the previous behavior, and caused this bug.
What is the current behavior?
IME not work in the above scenario
What is the updated/expected behavior with this PR?
IME works.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues