Fix stuck internal macOS modifier keys #16788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
os-macos
customer-priority
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Aug 25, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes the internal state of modifier keys that were getting stuck on macOS if the window lost the focus while a key was pressed. (Consequently, pressing the same modifier key again was ignored the first time.)
How was the solution implemented (if it's not obvious)?
Internal modifiers are synchronized back when the window gets the focus.