ResourceProvider upgrade #16928
Merged
ResourceProvider upgrade #16928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
commented
Sep 4, 2024
| using Avalonia.Collections; | ||
| using Avalonia.Controls; | ||
| using Avalonia.Styling; | ||
|
|
||
| namespace Avalonia.Themes.Fluent; | ||
|
|
||
| internal class ColorPaletteResourcesCollection : AvaloniaDictionary<ThemeVariant, ColorPaletteResources>, IResourceProvider | ||
| internal sealed class ColorPaletteResourcesCollection : ResourceProvider, IDictionary<ThemeVariant, ColorPaletteResources> |
There was a problem hiding this comment.
Lots of new boilerplate, because C# can't do multiple inheritance.
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
grokys
approved these changes
Sep 12, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR makes ResourceProvider abstract class more usable/appealing to developers to inherit.
Before
ResourceProvider, the only choice for custom resource dictionaries was to use private APIs.In 11.2 we got
ResourceProvider, but it didn't inherit AvaloniaObject, making it less useful, when developer needs any dynamic property.