[macOS] Fixes stuck mouse buttons after drag #17035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR resets the internal mouse button states when a drag operation is started on macOS, as we don't get
mouseUpevents anymore when a dragging session is in progress.Note that all states are reset on drag since we don't really know what other buttons might be pressed/released during dragging.
Also, it matches the observed behavior on macOS: all pressed buttons must be released for the drop events to be triggered, and not only the one that initiated the drag.
What is the current behavior?
After dragging, the initial mouse button is stuck.
What is the updated/expected behavior with this PR?
The mouse button isn't stuck anymore.
Fixed issues