[Browser] Add dotnet/runtime#109289 workaround #17507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
os-browser
backport-candidate-11.2.x
|
You can test this PR using the following package version. |
MrJul
approved these changes
Nov 14, 2024
10 tasks
maxkatz6
added a commit
that referenced
this pull request
Nov 14, 2024
* Add dotnet/runtime#109289 workaround * Add target framework version condition
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As it seems, this WASM bug was moved to .NET 10.0 milestone, making it unclear, if .NET 9 will ever work with SkiaSharp out of the box.
Thanks to the discussion in dotnet/runtime#109289, we have a workaround.
Workaround is automatically included on any .NET 9+ target, unless DisableIssue109289Workaround is set to true.
Fixed issues
Fixes #17416