Fix random test failures and add empty dispatcher verification to tests #17628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Nov 30, 2024
maxkatz6
added
the
backport-candidate-11.2.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 19, 2024
…ts (#17628) * Add VerifyEmptyDispatcherAfterTestAttribute * Use VerifyEmptyDispatcherAfterTest and fix failing tests * Remove unsupported timeout from sync xUnit tests
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes random test failures caused by new tests added in #17570. Those tests weren't properly isolated (which should be done using
ScopedTestsBaseorUnitTestApplication.Start()), pushing some jobs to the dispatcher which were executed from another unrelated test, causing it to fail.This is a very common situation, which is hard to diagnose: it depends on the tests order and when the dispatcher effectively ran jobs.
To better handle this condition, this PR adds a new
VerifyEmptyDispatcherAfterTestAttributewhich checks that no pending jobs remain on the dispatcher after a test. It's applied on the assembly directly, which required an update of xUnit to work. As a result, several other test classes have been fixed.Timeouts have been removed from xUnit synchronous headless tests, since they never worked in the first place, and result in errors after the xUnit update.