Fix TextBlock re-measure in infinite container #17638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
added
bug
regression
backport-candidate-11.1.x
|
Looks good |
Gillibald
approved these changes
Nov 29, 2024
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Dec 19, 2024
* Add failing test for TextBlock * Fix TextBlock re-measure in infinite container * Fix outdated test --------- Co-authored-by: Max Katz <maxkatz6@outlook.com>
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes a
TextBlocknot re-measuring itself it it's contained in an infinite container and itsTextLayoutis created.See #17637 for details.
A unit test has been added.
How was the solution implemented (if it's not obvious)?
An invalid constraint (
NaN) is set at the start, so it will never match anything else by default.Fixed issues