Filter pointer pressed events from disabled sub-menu items #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointer clicks on disabled and non-interactive items in sub-menus are bubbled up to the sub-menu's parent, causing the sub-menu popup to be closed when it is expected to remain open. This scenario is identified and filtered out by searching for a popup in the logical tree between the source and the handler. Fixes AvaloniaUI#6412.
|
|
grokys
approved these changes
Nov 4, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Nov 23, 2021
Filter pointer pressed events from disabled sub-menu items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Clicking a disabled menu item in a top-level sub-menu unexpectedly closes the sub-menu. This pull request contains code that identifies this scenario and filters it out.
What is the current behavior?
PointerPressedevents on disabled and non-interactive items in sub-menus are not handled until they are bubbled up to the sub-menu's parent. If the parent is a top-level menu item, the sub-menu is unexpectedly closed.What is the updated/expected behavior with this PR?
The code in this pull request identifies
PointerPressedevents that bubble up from sub-menus by looking for a popup in the logical tree between the event source and its handler. In this case, the sub-menu remains open as expected.Checklist
Fixed issues
Fixes #6412