Update NumericUpDown template MinWidth #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
commented
Oct 31, 2021
grokys
approved these changes
Nov 4, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Nov 23, 2021
Update NumericUpDown template MinWidth
maxkatz6
added a commit
that referenced
this pull request
Dec 22, 2021
Previous numericupdown bugfix (see https://github.com/AvaloniaUI/Avalonia/pull/6830/files) introduced another bug (see #7230 (comment)). This PR solves both problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Both ButtonSpinner and TextBox have style setters for MinWidth, which are not changed, when you change NumericUpDown min width to another value. Because of that developer needs to change same value in three places.
This PR simplifies it.