DataGridColumn - fix LayoutRoundedWidth with DPI scaling applied #6860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Nov 25, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Dec 7, 2021
DataGridColumn - fix LayoutRoundedWidth with DPI scaling applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes LayoutRoundedWidth for DPI scaling other than 1.
What is the current behavior?
The current calculation does not account for DPI scaling and produces artifacts, especially with header borders.
repro steps
What is the updated/expected behavior with this PR?
Vertical separator lines should be visible at all times.
Interestingly cells calculation is different (because it is visual). But I believe now it will be the same.
How was the solution implemented (if it's not obvious)?
I don't know this code very well but I used the same layout rounding as other visuals and it seems to work just well enough.