fix: Make DataGridColumn.Header and .HeaderTemplate a DirectProperty #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this enables Binding and DynamicResource usage
|
Hm, didn't thought that binding is useful here. But dynamic resource definitely is. |
maxkatz6
approved these changes
Dec 7, 2021
|
@maxkatz6 Binding is useful if you want to change the Header based on a Language which may change during runtime. At least for me it would be useful |
danwalmsley
pushed a commit
that referenced
this pull request
Dec 7, 2021
…perty fix: Make DataGridColumn.Header and .HeaderTemplate a DirectProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Change
HeaderandHeaderTemplateto be aDirectPropertyWhat is the current behavior?
Both Properties are "normal" Propeties, so no Binding is supported
What is the updated/expected behavior with this PR?
Allow both Properties to be bindable
How was the solution implemented (if it's not obvious)?
Changed the properties to be a
DirectPropertyChecklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #7093