Enable nullable warnings as errors on projects which enabled Nullable Reference Types #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nullable annotations on netstandard2.0 are incomplete and incorrect in places. Ignore nullable warnings on netstandard2.0 and make them errors on later target frameworks.
The projects that have nullable reference types enabled are now generating errors instead of warnings, so fix those errors.
Takoooooo
reviewed
Dec 15, 2021
Comment on lines
+8
to
+9
| <WarningsAsErrors Condition="'$(TargetFramework)' != 'netstandard2.0'">$(WarningsAsErrors);nullable</WarningsAsErrors> | ||
| <NoWarn Condition="'$(TargetFramework)' == 'netstandard2.0'">$(NoWarn);nullable</NoWarn> |
There was a problem hiding this comment.
I am curious why do we need NoWarn here? I think WarningsAsErrors wouldn't simply work for projects with netstandard2.0 tfm. Also what $(WarningsAsErrors); does here? Do we need it here?
There was a problem hiding this comment.
WarningsAsErrors makes all nullable warnings as errors. Enabled for net6.
NoWarn makes all nullable warning as nothing. Enabled for netstandard.
There was a problem hiding this comment.
Also what $(WarningsAsErrors); does here
This causes the setting listed here to be appended to the existing WarningsAsErrors value, so we don't overwrite any values already set for this property.
maxkatz6
approved these changes
Dec 15, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Dec 20, 2021
…le-errors Enable nullable warnings as errors on projects which enabled Nullable Reference Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
netstandard2.0are incomplete and incorrect in places. Ignore nullable warnings onnetstandard2.0and promote them from warnings to errors on later target frameworks.