Disabled button can be pressed issue/bug

[Abdesol]

What does the pull request do?

Add IsEffectivelyEnabled condition to OnClick(from Button)

What is the updated/expected behavior with this PR?

If a controller is disabled(IsEnabled set to false), The Click event won't fire(work) unless the button is enabled.

Fixed issues

Fixes #6957

[Abdesol]

I added the test in the sandbox. If I did the test in the wrong place, let me know.

[maxkatz6]

Thanks.
For tests you need to create a new test method in tests project. You can add it in this file https://github.com/AvaloniaUI/Avalonia/blob/master/tests/Avalonia.Controls.UnitTests/ButtonTests.cs
I think you can copy and edit this specific method https://github.com/AvaloniaUI/Avalonia/blob/master/tests/Avalonia.Controls.UnitTests/ButtonTests.cs#L273-L284 it already does what you need to test (raises click on some event). You just need to disable button in your test method and check that event was not raised.

p.s. it seems like these tests "Button_Invokes_CanExecute_When_CommandParameter_Changed" and "Raises_Click_When_AccessKey_Raised" are mixed, probably somebody renamed incorrectly by mistake.

[maxkatz6]

Also you can just push commits to the same branch, you don't need to recreate PR

[Abdesol]

oh my bad.
I made a mistake in the test the assert should have been 0 ; (
Let me fix that

[maxkatz6]

Looks good to me

[maxkatz6]

Thanks!