Progress Bar progress text implementation in FluentTheme #7288
Conversation
|
This images show the previous behaviour before fix and after the fix. |
|
What happens to the percentage text color when progress is >=50%. Seems like it wouldn't be visible.
|
Why? ShowProgressText is already there and disabled by default. @Abdesol default progress bar is somewhat 4px height, right? Do you need to adjust height as well if you set ShowProgressText to true or is it automatically done by current layout? |
| @@ -21,6 +21,7 @@ | |||
| <Setter Property="Template"> | |||
| <ControlTemplate> | |||
| <Border x:Name="ProgressBarRoot" ClipToBounds="True" Background="{TemplateBinding Background}" BorderBrush="{TemplateBinding BorderBrush}" BorderThickness="{TemplateBinding BorderThickness}" CornerRadius="{TemplateBinding CornerRadius}"> | |||
| <Grid> | |||
There was a problem hiding this comment.
If there is no row or columns, better to go with Panel instead. Less overhead.
There was a problem hiding this comment.
What happens to the percentage text color when progress is >=50%. Seems like it wouldn't be visible.
- I think lightweight resource and potentially another brush property are needed to control this.
- A new property should be added to disable this without re-templating.
The Default theme has a similar issue. I will try to make a new pr to fix both of them in the near future.
There was a problem hiding this comment.
If there is no row or columns, better to go with Panel instead. Less overhead.
Fixed that on the current commit.
Did not know that, sorry |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
@Abdesol in default theme text is written with default text foreground (white/black depending on dark mode). Probably it makes sense to do the same here? |
To fix the issue consistently, text color should be the same as with the ToggleButton which faces the same issue. I would just double check but the SystemControlForegroundBaseHighBrush should be the correct resource. |
…mControlForegroundBaseHighBrush
oh yeah. Changed that on the current commit. |
|
You can test this PR using the following package version. |
Progress Bar progress text implementation in FluentTheme
What does the pull request do?
Add a progress text to a progress bar in fluent theme.
What is the current behavior?
ProgressBar ShowProgressText doesn't show the progress text.
What is the updated/expected behavior with this PR?
If the progress par ShowProgressText is set to true, it will show the progress text/status.
Fixed issues
Fixes #7255