Check for null visual parent. #7298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shouldn't be possible to come across a null visual parent here because the visual should be attached to the visual tree, but according to #6930, it is. Because we don't have a repro here, defensively return a null value instead of throwing if we hit this case.
|
You can test this PR using the following package version. |
danwalmsley
approved these changes
Jan 3, 2022
danwalmsley
approved these changes
Jan 3, 2022
grokys
added a commit
that referenced
this pull request
Jan 10, 2022
It shouldn't be possible to come across a null visual parent here because the visual should be attached to the visual tree, but according to #6930, it is. Because we don't have a repro here, defensively return a null value instead of throwing if we hit this case.
|
@grokys Are you sure this was backported? I don't see |
|
Yeah I think it was: you can see here https://github.com/AvaloniaUI/Avalonia/commits/stable/0.10.x?after=d504daf0e00f3b90f48cb9c2e941d3880367a8e5+34&branch=stable%2F0.10.x if you search for |
|
It was merged on Jan 10 though which is after the last release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes an exception in
SceneBuilderreported in #6930.It shouldn't be possible to come across a null visual parent here because the visual should be attached to the visual tree, but according to #6930, it is. Because we don't have a repro here, defensively return a null value instead of throwing if we hit this case.
Also because we don't have a repro, I wasn't able to write a unit test to cover this.
Fixed issues
Fixes #6930.