Fixed ITopLevelImpl API misuse, added validating layer #7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Jan 16, 2022
|
What's the advantage of this over simply nulling out the platform impl on dispose and enabling nullable reference types? |
|
This PR nulls out the platform impl on dispose. The validating layer is there to make sure that it's actually not used afterwards. |
grokys
added a commit
that referenced
this pull request
Jan 31, 2022
#7369 introduced a validating layer over `WindowBase.PlatformImpl` that is only enabled in debug mode. This validating layer was causing unit tests to fail in debug mode but not on CI which runs tests in release mode. Fix the problems: - `PopupRoot` was not correctly disposing itself on `Dispose` - make it call `HandleClosed` in order to perform the same steps as when the popup is closed via other means - Some unit tests try to access the `PlatformImpl` to get hold of a mock. Added `ValidatingWindowImpl.Unwrap` to allow this - `ValidatingWindowBaseImpl.Activated` was setting the wrong property on the wrapped `PlatformImpl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platform backends like Win32 silently swallow errors when IXXXImpl APIs are called after window has been destroyed. X11 and macOS will either crash with a managed exception or just segfault, because it's not valid to use an object after it has been disposed.
Since quite a lot of developers only check their changes on Windows, this PR introduces a platform backend equalizer that would just throw ObjectDisposedException before even calling into said backend.
Currently it's only enabled in
Debugconfiguration, will enable for Release in a month or two.This PR also fixes a problem with:
#7323
#7272
#7245
#7367