-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nullable annotations to Avalonia.Controls. #7477
Conversation
You can test this PR using the following package version. |
I am pretty sure we will come back to this after merging this PR anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two sits review done. If I haven't missed anything (I probably have), it looks good.
Only some minor comments.
And merge conflicts are there.
Made the decision to return a null `TextLayout` when `TextPresenter.Foreground` is null for consistency with our other usages of null brushes, though not 100% sure this is correct.
@maxkatz6 you're a hero for wading through this! 🥇 Responded to your comments and fixed merge conflicts. We just need a quick bit of input from @kekekeks and @danwalmsley on a couple of those. @Gillibald please let me know if the null handling of |
You can test this PR using the following package version. |
What does the pull request do?
Adds nullable annotations to Avalonia.Controls and fixes resulting errors in Avalonia.Diagnostics.
This is a big one! I'm not sure I've got everything right here, so if you're responsible for a control/class here and the annotations look wrong to you, please simply push a fix to this branch if you have write access, otherwise comment and I'll fix.