Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7519 - Reset fb and depth buffer Ids once they are deleted #7528

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix #7519 - Reset fb and depth buffer Ids once they are deleted #7528

merged 2 commits into from
Feb 4, 2022

Conversation

odalet
Copy link
Contributor

@odalet odalet commented Feb 4, 2022

What does the pull request do?

This fixes issue #7519 (artifacts appearing in OpenGLControlBase when hidden then shown again)

What is the current behavior?

See this video:

Before.mp4

What is the updated/expected behavior with this PR?

No artifacts when hiding/showing again the control

How was the solution implemented (if it's not obvious)?

  • Simply resetted the depth buffer id to 0 when it is deleted
  • Note: I did the same with the framebuffer id. Although not strictly necessary, I thought it'd be better for consistency purpose.

Checklist

None of these, but here is a video of the behavior after the fix:

After.mp4

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0018489-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@kekekeks kekekeks enabled auto-merge February 4, 2022 19:14
@kekekeks kekekeks merged commit fb7cf3d into AvaloniaUI:master Feb 4, 2022
@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0018491-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@odalet odalet deleted the fix-OpenGLControlBase branch February 7, 2022 08:56
@maxkatz6 maxkatz6 added the bug label Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants