Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vortice.Windows migration. #7947

Closed
wants to merge 9 commits into from
Closed

Vortice.Windows migration. #7947

wants to merge 9 commits into from

Conversation

amerkoleci
Copy link
Contributor

@amerkoleci amerkoleci commented Apr 8, 2022

What does the pull request do?

Migrates from SharpDX to Vortice.Windows

What is the current behavior?

Uses SharpDX for D2D1, WIC and DirectWrite

What is the updated/expected behavior with this PR?

Everything should work as before, when using SharpDX

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

This changes whole windows rendering part.

@amerkoleci
Copy link
Contributor Author

All tests works now!

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0019804-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@amerkoleci
Copy link
Contributor Author

Ok, we should be fine now, you can merge if you want.

Thanks

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 0.10.999-cibuild0019823-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

@amerkoleci amerkoleci closed this Apr 14, 2022
@amerkoleci amerkoleci deleted the vortice branch April 14, 2022 18:04
@danielmayost
Copy link
Contributor

danielmayost commented Apr 21, 2022

@amerkoleci why?

@amerkoleci
Copy link
Contributor Author

@amerkoleci why?

This was mine 3rd PR for Vortice migration and received 0 feedback, so I won't bother migrating anymore :D

@Gillibald
Copy link
Contributor

We had some internal discussion about this just before you closed this. Just keep in mind that we might be busy and it takes some time to give feedback.

@amerkoleci
Copy link
Contributor Author

We had some internal discussion about this just before you closed this. Just keep in mind that we might be busy and it takes some time to give feedback.

I can immagine but PR #5831 broked entire integration, this PR is in pending state as well: #7753

And I can immagine being busy, don't worry, but without feedback is difficult for me to keep PR updated with master branch.

@grokys
Copy link
Member

grokys commented Apr 21, 2022

You did only give us 3 days from "this is ready" to "closing due to lack of feedback" - sorry but it can sometimes take us a long time to give feedback on PRs, especially ones that change our core infrastructure like this.

PR #5831 broked entire integration

#5831 (comment)

@amerkoleci
Copy link
Contributor Author

You did only give us 3 days from "this is ready" to "closing due to lack of feedback" - sorry but it can sometimes take us a long time to give feedback on PRs, especially ones that change our core infrastructure like this.

PR #5831 broked entire integration

#5831 (comment)

Yeah sorry, Avalonia is huge project and its difficult to keep track of all issues/PR, I can immagine being difficult for you as well, sorry for closing very quickly :) I would gladly submit new PR is it can give benefit to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants