-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vortice.Windows migration. #7947
Conversation
All tests works now! |
You can test this PR using the following package version. |
Ok, we should be fine now, you can merge if you want. Thanks |
You can test this PR using the following package version. |
@amerkoleci why? |
This was mine 3rd PR for Vortice migration and received 0 feedback, so I won't bother migrating anymore :D |
We had some internal discussion about this just before you closed this. Just keep in mind that we might be busy and it takes some time to give feedback. |
I can immagine but PR #5831 broked entire integration, this PR is in pending state as well: #7753 And I can immagine being busy, don't worry, but without feedback is difficult for me to keep PR updated with master branch. |
You did only give us 3 days from "this is ready" to "closing due to lack of feedback" - sorry but it can sometimes take us a long time to give feedback on PRs, especially ones that change our core infrastructure like this.
|
Yeah sorry, Avalonia is huge project and its difficult to keep track of all issues/PR, I can immagine being difficult for you as well, sorry for closing very quickly :) I would gladly submit new PR is it can give benefit to the project. |
What does the pull request do?
Migrates from SharpDX to Vortice.Windows
What is the current behavior?
Uses SharpDX for D2D1, WIC and DirectWrite
What is the updated/expected behavior with this PR?
Everything should work as before, when using SharpDX
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
This changes whole windows rendering part.