Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deferred InvalidateMeasure #249

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

danipen
Copy link
Collaborator

@danipen danipen commented Aug 30, 2022

Removed the deferred InvalidateMeasure call.

  • No noticeable change in performance (tested with and without it in macOS and windows, and no perf changes).
  • It obscures the API usage. Basically, when you want/need to access the VisualLines you need to use the Dispatcher too (you need to wait until at least until the control has completed a measuring cycle to ensure that the visual lines have been generated). The same thing happens for scrolling, after scrolling you need to defer any op until the visual lines have been generated. Removing it would make all usages easier since it would be always synchronous. Virtualization makes things fast enough in my opinion.

@danipen danipen requested a review from Gillibald August 30, 2022 10:47
@danipen danipen merged commit 1771133 into master Aug 30, 2022
@Takoooooo Takoooooo deleted the remove-deferred-invalidate-visual branch November 30, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants