Fix allow scroll below document #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the _documentSize var and directly use the _scrollExtent, like the upstream project. Cleanup commented code.
This commit fixes AllowScrollBelowDocument option. The events chain in the ScrollViewer prevented AvaloniaEdit to reserve more space because when the scrollbar reached the max viewport no new events were send, so the code did not work as WPF. Instead, I changed the implementation to behave as Visual Studio / Visual Studio Code / Sublime. They basically adds an extra Bounds.Height - minimum distance (tipically one line) when the option is enabled.
and set them to the TextView to cause it to call InvalidateDefaultTextMetrics()
…oll jumps just align the line top to the view, as other editor do (VS, VSCode, Sublime)
Gillibald
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
AllowScrollBelowDocumentoption. The event chain in the ScrollViewer prevented AvaloniaEdit to reserve more space for the viewport, because when the scrollbar reached the max viewport no new events sent, so the code did not work as WPF.After these fixes, when the option
AllowScrollBelowDocumentis enabled, the TextView adds an extra height ofBounds.Height - DefaultLineHeightso the user is able to scroll. We ensure that at least one line is visible.I also removed the margins used when the TextEditor is clicked, or the line is being edited. It used a margin of 5px for mouse clicks and a 30px margin when editing text. This helps to maintain the scroll more stable when editing or clicking the textView in the edges.
Some demo:
allow-scroll-below-document.mp4
Fixes #141.