Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to prevent folding crashes #273

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Attempt to prevent folding crashes #273

merged 1 commit into from
Oct 14, 2022

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Oct 14, 2022

Fixes: #272

@danipen danipen mentioned this pull request Oct 14, 2022
@HendrikMennen
Copy link
Contributor

HendrikMennen commented Oct 14, 2022

For me this fixes the crash :)

Still folding is a bit broken compared to last version, AllowScrollBelowDocument needs to be activated to avoid visual glitches

@Gillibald Gillibald changed the title Attempt to prevent foldin crashes Attempt to prevent folding crashes Oct 14, 2022
@Numpsy
Copy link

Numpsy commented Oct 14, 2022

The error I was seeing seems ok with this change as well :-)

@danipen
Copy link
Collaborator

danipen commented Oct 14, 2022

@HendrikMennen can you describe the issue? I disabled AllowToScrollBelowDocument and it seems to work fine for me:
folding

@HendrikMennen
Copy link
Contributor

If I collapse something at the bottom of an element it looks like this.
image

Once I force it to redraw by resizing or scrolling the issue is resolved.

@danipen
Copy link
Collaborator

danipen commented Oct 14, 2022

Could you provide a repro case in the demo application?

@HendrikMennen
Copy link
Contributor

Okay nevermind it was my fault, sorry! It works perfectly now :)

@danipen
Copy link
Collaborator

danipen commented Oct 14, 2022

Glad to hear that!

@danipen danipen merged commit 6159ad9 into master Oct 14, 2022
@Takoooooo Takoooooo deleted the fixes/foldingCrashes branch November 30, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folding crash
4 participants