Update to preview 5 #305
Merged
Update to preview 5 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danipen
approved these changes
Feb 6, 2023
| @@ -68,14 +68,9 @@ public override TextRun CreateTextRun(int startVisualColumn, ITextRunConstructio | |||
| offset, | |||
| DocumentLength - relativeOffset); | |||
|
|
|||
| var bufferOffset = RelativeTextOffset; | |||
| //var bufferOffset = RelativeTextOffset; | |||
There was a problem hiding this comment.
Can we remove this commented code?
|
@Gillibald after the upgrade, the button text, and the status bar text is black instead of white. Are we using the dark theme for the application? |
I guess we should use ThemeVariant Light in Demo app |
|
Ping me when this PR will be merged i will make a release |
|
@Takoooooo it is already merged. You can make the release. |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.